Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MovingLeastSquaresOMP #2456

Closed
SergioRAgostinho opened this issue Sep 25, 2018 · 0 comments · Fixed by #3119
Closed

Deprecate MovingLeastSquaresOMP #2456

SergioRAgostinho opened this issue Sep 25, 2018 · 0 comments · Fixed by #3119
Labels
good first issue Skills/areas of expertise needed to tackle the issue module: surface
Milestone

Comments

@SergioRAgostinho
Copy link
Member

After C++14 migration remember to deprecate MovingLeastSquaresOMP.

/** \brief MovingLeastSquaresOMP implementation has been merged into MovingLeastSquares for better maintainability.
* \note Keeping this empty child class for backwards compatibility.
* \author Robert Huitl
* \ingroup surface
*/
template <typename PointInT, typename PointOutT>
class MovingLeastSquaresOMP : public MovingLeastSquares<PointInT, PointOutT>
{
public:
/** \brief Constructor for parallelized Moving Least Squares
* \param threads the maximum number of hardware threads to use (0 sets the value to 1)
*/
MovingLeastSquaresOMP (unsigned int threads = 1)
{
this->setNumberOfThreads (threads);
}
};
}

@SergioRAgostinho SergioRAgostinho added good first issue Skills/areas of expertise needed to tackle the issue module: surface labels Sep 25, 2018
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.10.0 milestone Sep 25, 2018
@SergioRAgostinho SergioRAgostinho added the needs: pr merge Specify why not closed/merged yet label Sep 25, 2018
@SergioRAgostinho SergioRAgostinho changed the title Deprecate new MovingLeastSquaresOMP Deprecate MovingLeastSquaresOMP Sep 25, 2018
@taketwo taketwo removed the needs: pr merge Specify why not closed/merged yet label Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Skills/areas of expertise needed to tackle the issue module: surface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants