Skip to content

Remove the wrong comment and fix the benchmark comment formatting #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YigitElma merged 2 commits into from
Oct 2, 2025
Merged

Remove the wrong comment and fix the benchmark comment formatting #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be52237
remove the wrong comment and fix the benchmark comment formatting
YigitElma Oct 1, 2025
862f2e2
Merge branch 'master' into yge/hotfix-ci
YigitElma Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ coverage:
patch:
default:
informational: false
if_not_found: success # for 'only-docs-comments' labeled PRs
project:
default:
informational: false
threshold: 2.0
if_not_found: success # for 'only-docs-comments' labeled PRs
github_checks:
annotations: true
4 changes: 2 additions & 2 deletions tests/benchmarks/compare_bench_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@
commit_msg_lines.append(line)

commit_msg_lines.append("```")
commit_msg_lines += (
commit_msg_lines.append(
"\n\nGithub CI performance can be noisy. When evaluating the "
"benchmarks, developers should take this into account.\n"
+ "benchmarks, developers should take this into account.\n"
)
commit_msg_lines = [line + "\n" for line in commit_msg_lines]
print("".join(commit_msg_lines))
Expand Down
Loading