-
Notifications
You must be signed in to change notification settings - Fork 41
Remove the wrong comment and fix the benchmark comment formatting #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 1.72 % | 3.975e+03 | 4.044e+03 | 68.49 | 33.54 | 31.33 |
test_proximal_jac_w7x_with_eq_update | -0.68 % | 6.761e+03 | 6.715e+03 | -46.15 | 159.20 | 157.98 |
test_proximal_freeb_jac | 0.25 % | 1.318e+04 | 1.322e+04 | 32.40 | 77.20 | 76.59 |
test_proximal_freeb_jac_blocked | 1.34 % | 7.531e+03 | 7.632e+03 | 101.00 | 67.78 | 67.89 |
test_proximal_freeb_jac_batched | -0.02 % | 7.594e+03 | 7.593e+03 | -1.17 | 68.39 | 68.49 |
test_proximal_jac_ripple | 1.59 % | 7.508e+03 | 7.628e+03 | 119.43 | 69.30 | 68.80 |
test_proximal_jac_ripple_spline | 0.02 % | 3.476e+03 | 3.477e+03 | 0.81 | 71.42 | 71.20 |
test_eq_solve | 0.20 % | 2.046e+03 | 2.050e+03 | 4.04 | 126.46 | 126.36 |For the memory plots, go to the summary of |
Contributor
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_midres | +7.47 +/- 8.05 | +5.04e-02 +/- 5.43e-02 | 7.25e-01 +/- 3.0e-02 | 6.75e-01 +/- 4.5e-02 |
test_build_transform_fft_highres | +5.19 +/- 5.03 | +4.77e-02 +/- 4.62e-02 | 9.67e-01 +/- 1.7e-02 | 9.19e-01 +/- 4.3e-02 |
test_equilibrium_init_lowres | +3.25 +/- 11.91 | +1.48e-01 +/- 5.43e-01 | 4.71e+00 +/- 3.3e-01 | 4.56e+00 +/- 4.3e-01 |
test_objective_compile_atf | +5.75 +/- 4.71 | +3.56e-01 +/- 2.92e-01 | 6.55e+00 +/- 2.5e-01 | 6.20e+00 +/- 1.5e-01 |
test_objective_compute_atf | +12.62 +/- 22.38 | +2.73e-04 +/- 4.84e-04 | 2.44e-03 +/- 2.2e-04 | 2.16e-03 +/- 4.3e-04 |
test_objective_jac_atf | +6.67 +/- 2.39 | +1.16e-01 +/- 4.16e-02 | 1.86e+00 +/- 2.8e-02 | 1.74e+00 +/- 3.0e-02 |
test_perturb_1 | +3.43 +/- 4.59 | +4.89e-01 +/- 6.55e-01 | 1.47e+01 +/- 3.8e-01 | 1.42e+01 +/- 5.4e-01 |
test_proximal_jac_atf | +1.74 +/- 3.47 | +9.83e-02 +/- 1.96e-01 | 5.74e+00 +/- 1.8e-01 | 5.64e+00 +/- 8.4e-02 |
test_proximal_freeb_compute | +4.22 +/- 3.75 | +6.74e-03 +/- 5.99e-03 | 1.66e-01 +/- 4.7e-03 | 1.60e-01 +/- 3.7e-03 |
test_solve_fixed_iter | +3.88 +/- 5.00 | +1.15e+00 +/- 1.48e+00 | 3.08e+01 +/- 1.4e+00 | 2.96e+01 +/- 5.9e-01 |
test_objective_compute_ripple | +0.16 +/- 1.88 | +4.28e-03 +/- 4.90e-02 | 2.62e+00 +/- 1.9e-02 | 2.61e+00 +/- 4.5e-02 |
test_objective_grad_ripple | +0.79 +/- 1.85 | +3.70e-02 +/- 8.70e-02 | 4.74e+00 +/- 6.2e-02 | 4.70e+00 +/- 6.1e-02 |
test_build_transform_fft_lowres | -0.62 +/- 3.80 | -3.49e-03 +/- 2.12e-02 | 5.56e-01 +/- 2.0e-02 | 5.59e-01 +/- 7.8e-03 |
test_equilibrium_init_medres | -0.99 +/- 1.51 | -4.83e-02 +/- 7.35e-02 | 4.83e+00 +/- 4.0e-02 | 4.88e+00 +/- 6.2e-02 |
test_equilibrium_init_highres | -1.09 +/- 1.70 | -6.00e-02 +/- 9.36e-02 | 5.43e+00 +/- 3.2e-02 | 5.49e+00 +/- 8.8e-02 |
test_objective_compile_dshape_current | -0.25 +/- 1.66 | -8.41e-03 +/- 5.56e-02 | 3.34e+00 +/- 2.9e-02 | 3.35e+00 +/- 4.7e-02 |
test_objective_compute_dshape_current | -0.71 +/- 8.82 | -5.47e-06 +/- 6.84e-05 | 7.70e-04 +/- 4.3e-05 | 7.76e-04 +/- 5.3e-05 |
test_objective_jac_dshape_current | -3.19 +/- 19.94 | -1.06e-03 +/- 6.64e-03 | 3.23e-02 +/- 4.5e-03 | 3.33e-02 +/- 4.9e-03 |
test_perturb_2 | -0.18 +/- 1.19 | -3.03e-02 +/- 2.00e-01 | 1.68e+01 +/- 1.5e-01 | 1.68e+01 +/- 1.4e-01 |
test_proximal_jac_atf_with_eq_update | +1.10 +/- 0.69 | +1.50e-01 +/- 9.41e-02 | 1.38e+01 +/- 8.9e-02 | 1.37e+01 +/- 3.0e-02 |
test_proximal_freeb_jac | +1.17 +/- 6.95 | +5.86e-02 +/- 3.49e-01 | 5.08e+00 +/- 1.1e-01 | 5.02e+00 +/- 3.3e-01 |
test_solve_fixed_iter_compiled | +1.76 +/- 2.44 | +3.00e-01 +/- 4.15e-01 | 1.73e+01 +/- 3.8e-01 | 1.70e+01 +/- 1.8e-01 |
test_LinearConstraintProjection_build | +1.51 +/- 2.93 | +1.26e-01 +/- 2.44e-01 | 8.47e+00 +/- 2.0e-01 | 8.34e+00 +/- 1.5e-01 |
test_objective_compute_ripple_spline | -0.53 +/- 4.15 | -1.56e-03 +/- 1.21e-02 | 2.90e-01 +/- 9.2e-03 | 2.92e-01 +/- 7.9e-03 |
test_objective_grad_ripple_spline | +0.80 +/- 3.43 | +8.83e-03 +/- 3.78e-02 | 1.11e+00 +/- 2.8e-02 | 1.10e+00 +/- 2.6e-02 |Github CI performance can be noisy. When evaluating the benchmarks, developers should take this into account. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
+ Coverage 93.89% 95.73% +1.84%
==========================================
Files 100 100
Lines 27565 27565
==========================================
+ Hits 25881 26389 +508
+ Misses 1684 1176 -508 🚀 New features to boost your workflow:
|
dpanici
approved these changes
Oct 1, 2025
unalmis
approved these changes
Oct 2, 2025
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 14, 2025
…asmaControl#1948) - PlasmaControl#1946 didn't solve the codecov problem, this removes the misleading comment - There was a bug in benchmark disclaimer text ```python a = ["asd"] a.append("dfg") a += "qwe" for i in a: print(i) ``` ``` asd dfg q w e ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run_benchmarks
Run timing benchmarks on this PR against current master branch
skip_changelog
No need to update changelog on this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.