Fix generate_parameter_library macro on Windows #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft as I want first to test this solution in RoboStack/ros-jazzy#22 . |
The compilation of downstream packages worked fine, I think we can consider the PR ready for review, thanks! |
christophfroehlich
approved these changes
Feb 11, 2025
sea-bass
approved these changes
Feb 13, 2025
|
@traversaro Thanks! Do you want a patch release to be set up after this fix? |
I do not have a specific need for it. I added a patch locally on robostack, the important thing for me is to fix the problem upstream so in the long term we can remove the patch, but there is no hurry for doing a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
cmake -E echoto generate the deprecation message fails on Windows with a mysterious "CUSTOMBUILD : CMake error : %SRC_DIR%/build/include/controller_manager_parameters.hpp: no such file or directory" error. The problem is that<and>are special characters in Command Prompt. As an alternative solution, I generate the required string at configuration time viafile(WRITE, and just use that file to compose the final generated header.