Skip to content

Conversation

@samfreund
Copy link
Member

Description

This lets us perform better smoketests.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner December 16, 2025 06:54
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Dec 16, 2025
@samfreund samfreund requested a review from Gold856 December 16, 2025 06:58
Copy link
Member

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's would be more accurate to call the arg "platform" because architecture implies CPU architecture.

@samfreund samfreund force-pushed the refactor-plat-override branch from f84ac5a to 44cdfab Compare December 16, 2025 07:40
@crschardt
Copy link
Contributor

Should this PR include a test for the new platform option?

@samfreund
Copy link
Member Author

Should this PR include a test for the new platform option?

I'm not sure how precisely we could test it, since we can't actually run the jar from inside the jar itself. It will be tested in #2248 somewhat indirectly, and we've already confirmed the override works with Playwright; so I think it should be fine.

@samfreund
Copy link
Member Author

Combining with #2248

@samfreund samfreund closed this Dec 16, 2025
@samfreund samfreund deleted the refactor-plat-override branch December 16, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants