Integrate smoketests into image build #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samfreund
force-pushed
the
smokiest-test
branch
3 times, most recently
from
88320fd to
d033115
Compare
This comment was marked as outdated.
This comment was marked as outdated.
samfreund
force-pushed
the
smokiest-test
branch
2 times, most recently
from
8e4c929 to
629ff45
Compare
7 tasks
samfreund
force-pushed
the
smokiest-test
branch
from
629ff45 to
615d885
Compare
github-actions
bot
added
the
backend
samfreund
force-pushed
the
smokiest-test
branch
4 times, most recently
from
b61ac48 to
f2aeb57
Compare
samfreund
force-pushed
the
smokiest-test
branch
3 times, most recently
from
f238c19 to
87e6f68
Compare
samfreund
force-pushed
the
smokiest-test
branch
from
3118287 to
c59b54f
Compare
samfreund
force-pushed
the
smokiest-test
branch
from
4dd56ab to
ded27b6
Compare
Gold856
requested changes
Dec 17, 2025
samfreund
force-pushed
the
smokiest-test
branch
2 times, most recently
from
c5202c9 to
9855c26
Compare
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
Runs the smoketest on each image after we build it in CI. This helps ensure that we check every image that we build has the requisite JNI libraries, and that they can be loaded. This is needed cause we've been breaking that, and our current smoketests don't actually test all our libraries since some are gated behind platform checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runs the smoketest on each image after we build it in CI. This helps ensure that we check every image that we build has the requisite JNI libraries, and that they can be loaded. This is needed cause we've been breaking that, and our current smoketests don't actually test all our libraries since some are gated behind platform checks.
Meta
Merge checklist: