Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory: Enhance query_pools to include more information #124

Closed
msteiner96 opened this issue Sep 6, 2023 · 0 comments · Fixed by #128
Closed

Factory: Enhance query_pools to include more information #124

msteiner96 opened this issue Sep 6, 2023 · 0 comments · Fixed by #128
Assignees

Comments

@msteiner96
Copy link

msteiner96 commented Sep 6, 2023

Problem:
Currently, the query_pools function returns only an array of pool addresses. However, to provide users with a more comprehensive view of the pools and to facilitate various operations, we should consider extending this query to include additional information.

Solution:
Enriching the query_pools function to return more detailed information about each pool. Specifically, I suggest including the following data:

  1. Pool Tokens:

    • Addresses of both tokens involved in the pool.
    • Address of the LP (Liquidity Provider) Share token.
    • The current balance in the pool for each token.

    This information will allow the frontend to quickly identify the assets in each pool and their current holdings.

  2. Fees:

    • Include information about the fees associated with each pool.

Implementation Steps:
To implement this enhancement, the following steps are proposed:

  1. Update the query_pools function in the smart contract to include the requested information.
  2. Modify the documentation to reflect the changes made to the query function, ensuring that users and developers are aware of the expanded data available.
@gangov gangov self-assigned this Sep 7, 2023
@gangov gangov linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants