Factory: enhance query_pool #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Sep 8, 2023
|
Add two queries: |
… or in bulk. Refactors the logic of what's saved in ledger
…ols. Initially it didn't worked because the wasm hash of the lp_contract fro the setup.rs file is the same. Alternative doesn't work either
|
how are we supposed to test the functionality of the factory deploying multiple liquidity_pools when the lp_wasm_hash is the same every time we deploy a new liquidity_pool? |
|
btw what are the fees, something I couldn't understand |
Pair: adds function to query total_fee_bps for a pair
…th testing the deployment of multiple liquidity pools
…ration; Compare values of the new pairs in test
…hat will return 1:1 the struct needed in the Factory contract. Factory: refacts, extends the test and reduces the number of calls to the Pair contract.
ueco-jb
reviewed
Sep 14, 2023
…, updates tests. Pair: adds new field for the factory response. Updates CHANGELOG.md
gangov
deleted the
124-factory-enhance-query_pools-to-include-more-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory: refactors the storage, so it keeps more information about th…e liquidity pool