sv_clear: with zero SvREFCNT, call sv_free2, not sv_free #22843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards the bottom of `Perl_sv_clear`, there is a region described as being `* unrolled SvREFCNT_dec and sv_free2 follows: */`. This was introduced in Perl@5239d5c but the definitions of `Perl_sv_free`, `Perl_sv_free2`, and `SvREFCNT_dec` were updated in Perl@75a9bf9 and this region of code didn't get updated. The unrolling remains valid, but the call to `sv_free(sv)` ultimately boils down to a call to `sv_free2`, so this commit just goes there directly.
richardleach
force-pushed
the
hydahy/sv_clear-free-free2
branch
from
4bc1619 to
bb59fb2
Compare
tonycoz
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards the bottom of
Perl_sv_clear, there is a region described as being* unrolled SvREFCNT_dec and sv_free2 follows: */. This was originally accurate when introduced in 5239d5c but the definitions ofPerl_sv_free,Perl_sv_free2, andSvREFCNT_decwere updated in 75a9bf9 and this region of code didn't get updated to match.I'm unsure of how to best refactor this code region, but right now the call to
sv_free(sv)ultimately boils down to a call tosv_free2, so this commit just goes there directly.