sv_clear: with zero SvREFCNT, call sv_free2, not sv_free

richardleach · richardleach · commit 4bc1619cdf0a · 2024-12-05T23:10:26.000Z
Towards the bottom of `Perl_sv_clear`, there is a region described as being `* unrolled SvREFCNT_dec and sv_free2 follows: */`. This was originally accurate when introduced in 5239d5c but the definitions of `Perl_sv_free`, `Perl_sv_free2`, and `SvREFCNT_dec` were updated in 75a9bf9 and this region of code didn't get updated to match. I'm unsure of how to best refactor this code region, but right now the call to `sv_free(sv)` ultimately boils down to a call to `sv_free2`, so this commit just goes there directly.
diff --git a/sv.c b/sv.c
@@ -7125,7 +7125,7 @@ Perl_sv_clear(pTHX_ SV *const orig_sv)
             if (!sv)
                 continue;
             if (!SvREFCNT(sv)) {
-                sv_free(sv);
+                Perl_sv_free2(aTHX_ sv, 0);
                 continue;
             }
             if (--(SvREFCNT(sv)))

Original file line number	Diff line number	Diff line change
`@@ -7125,7 +7125,7 @@ Perl_sv_clear(pTHX_ SV *const orig_sv)`
`7125`	`7125`	`if (!sv)`
`7126`	`7126`	`continue;`
`7127`	`7127`	`if (!SvREFCNT(sv)) {`
`7128`		`- sv_free(sv);`
	`7128`	`+ Perl_sv_free2(aTHX_ sv, 0);`
`7129`	`7129`	`continue;`
`7130`	`7130`	`}`
`7131`	`7131`	`if (--(SvREFCNT(sv)))`