Various regex engine minor changes for @iabyn #20940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added as part of a different fix and was not properly reverted when that fix was put on hold. This should only be applied if we do adopt the patch which adds "start_new" and "end_new" to the regexp_paren_pair structure.
These two defines are related to each other, and even though VOLATILE_REF is not explicitly used in regexec.c which would require it being placed in regcomp.h, it is implicitly, and RE_PESSIMISTIC_PARENS *is* used in regexec.c. So put them both in regcomp.h and document them together. This adds copious documentation for what they both are for. RE_PESSIMISTIC_PARENS is effectively a "build option" (although intended for debugging regex engine bugs only). VOLATILE_REF is the name of a flag which is used to mark REF nodes as requiring special backtracking support in regexec.c
and standardized member order, and line up comments and struct members and other whitspace fixes. The internal tabs and messed up layout was hurting my eyes.
We use U16 for various internal logic related to parens. If we exceed this count stuff is going to go silently wrong. Might as well throw a proper error during compilation to detect this.
…erbar The leading underbar is reserved by C. These defines are debugging only "recursion" depth related counters injected into the function macro wrappers when a function is marked as 'W', much the same way that aTHX_ and pTHX_ are when building under threaded builds. The functions are expected to incremented the depth parameter themselves. Note that "recursion" is quoted above because in practice currently they are only used by the regex engine when recursing virtually, and they do not relate to true C stack related recursion. (But they could be used for tracking C level recursion under debugging if someone needed it.)
This makes it easier to debug, and type checks parameters and the like. It does make it somewhat slower in debug mode, but so what.
This makes it easier to debug, and type checks parameters and the like. It does make it somewhat slower in debug mode, but so what.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN #20918 (comment) @iabyn asked for some followups.
Also includes two other changes I noticed when working on the above: