[Pauli4] PauliWord and PauliSentence Documentation #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qottmann
added a commit
that referenced
this pull request
Jan 11, 2024
Adding subtraction for PauliWord and PauliSentence to have full pauli arithmetic together with [Pauli1](#4989) and [Pauli 2](#5001). see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), [Pauli5](#5018) --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
albi3ro
approved these changes
Jan 15, 2024
lillian542
reviewed
Jan 15, 2024
lillian542
reviewed
Jan 15, 2024
lillian542
reviewed
Jan 15, 2024
lillian542
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Left some small comments wrt how a few things are rendering. Looks good, thanks @Qottmann! 🚀
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
|
Docs look good now, thanks for spotting those! |
Qottmann
added a commit
that referenced
this pull request
Jan 17, 2024
Qottmann
added a commit
that referenced
this pull request
Jan 19, 2024
#5054) Following discussion here](#5017 (comment)) changing the default behavior of products between two `PauliWord` instances. old (see comment in discussion) ~~One thing I am still unsure about at the moment is for pure tensor products (where no coefficient is raised). E.g.~~ ``` pw1 = PauliWord({0:"X"}) pw2 = PauliWord({1:"X"}) ``` ~~I would find it counterintuitive to get a PauliSentence from `pw1 @ pw2` but would expect `PauliWord({0:"X", 1:"X"})`~~
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
Adding a scalar product to PauliWord and PauliSentence. This includes moving `*` $\Rightarrow$ `@` with legacy support for the case of multiplying `pw1 * pw2` This also introduces a deprecation cycle for `pw1 * pw2` type operations see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), [Pauli5](#5018) --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
…#5001) Adding cross-functionality for additions between PauliSentence, PauliWord and scalars. This now allows to intuitively add them to each other, e.g. ```python XX = PauliWord({0:"X", 1:"X"}) YY = PauliWord({0:"Y", 1:"Y"}) H = 0.5 * XX + 0.7 * YY >>> isinstance(H, PauliSentence) True ``` see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), [Pauli5](#5018) --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
Adding subtraction for PauliWord and PauliSentence to have full pauli arithmetic together with [Pauli1](#4989) and [Pauli 2](#5001). see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), [Pauli5](#5018) --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
Next PR after [Pauli1](#4989), [Pauli2](#5001) and [Pauli3](#5003) that all build on top of each other, adding documentation (and some integration tests) see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), [Pauli5](#5018) --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
#5054) Following discussion here](#5017 (comment)) changing the default behavior of products between two `PauliWord` instances. old (see comment in discussion) ~~One thing I am still unsure about at the moment is for pure tensor products (where no coefficient is raised). E.g.~~ ``` pw1 = PauliWord({0:"X"}) pw2 = PauliWord({1:"X"}) ``` ~~I would find it counterintuitive to get a PauliSentence from `pw1 @ pw2` but would expect `PauliWord({0:"X", 1:"X"})`~~
albi3ro
added a commit
that referenced
this pull request
Feb 9, 2024
Work in progress, some concepts like how best to treat identities need some fine tuning. see also [Pauli1](#4989), [Pauli2](#5001), [Pauli3](#5003), [Pauli4](#5017), on top of which this PR builds; as well as [Pauli5](#5018) --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR after Pauli1, Pauli2 and Pauli3 that all build on top of each other, adding documentation (and some integration tests)
see also Pauli1, Pauli2, Pauli3, Pauli4, Pauli5