Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pauli2] Extend addition functionality of PauliWord and PauliSentence #5001

Merged
merged 51 commits into from
Jan 11, 2024

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Jan 5, 2024

Adding cross-functionality for additions between PauliSentence, PauliWord and scalars.
This now allows to intuitively add them to each other, e.g.

XX = PauliWord({0:"X", 1:"X"})
YY = PauliWord({0:"Y", 1:"Y"})

H = 0.5 * XX + 0.7 * YY
>>> isinstance(H, PauliSentence)
True

see also Pauli1, Pauli2, Pauli3, Pauli4, Pauli5

@Qottmann Qottmann changed the title Pauliadd [Pauli2] Extend addition functionality of PauliWord and PauliSentence Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b72cca) 99.67% compared to head (6a0dc28) 99.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5001      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.02%     
==========================================
  Files         394      394              
  Lines       35616    35391     -225     
==========================================
- Hits        35500    35272     -228     
- Misses        116      119       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 self-requested a review January 10, 2024 16:16
Qottmann and others added 3 commits January 10, 2024 17:53
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for documentation stuff, see what you think :)

Base automatically changed from pauliproduct to master January 11, 2024 14:38
Qottmann added a commit that referenced this pull request Jan 11, 2024
Adding a scalar product to PauliWord and PauliSentence.
This includes moving `*` $\Rightarrow$ `@` with legacy support for the
case of multiplying `pw1 * pw2`

This also introduces a deprecation cycle for `pw1 * pw2` type operations

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
@Qottmann Qottmann enabled auto-merge (squash) January 11, 2024 15:01
@Qottmann Qottmann merged commit 4d726c5 into master Jan 11, 2024
@Qottmann Qottmann deleted the pauliadd branch January 11, 2024 15:34
Qottmann added a commit that referenced this pull request Jan 11, 2024
Adding subtraction for PauliWord and PauliSentence to have full pauli
arithmetic together with
[Pauli1](#4989) and [Pauli
2](#5001).

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Qottmann added a commit that referenced this pull request Jan 15, 2024
Next PR after
[Pauli1](#4989),
[Pauli2](#5001) and
[Pauli3](#5003) that all
build on top of each other, adding documentation (and some integration
tests)

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Qottmann added a commit that referenced this pull request Jan 17, 2024
…5018)

Not dependent on previous Pauli PRs
([Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017)).

Add support in `qml.matrix` to handle `PauliWord` and `PauliSentence`
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
Adding a scalar product to PauliWord and PauliSentence.
This includes moving `*` $\Rightarrow$ `@` with legacy support for the
case of multiplying `pw1 * pw2`

This also introduces a deprecation cycle for `pw1 * pw2` type operations

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
…#5001)

Adding cross-functionality for additions between PauliSentence,
PauliWord and scalars.
This now allows to intuitively add them to each other, e.g.

```python
XX = PauliWord({0:"X", 1:"X"})
YY = PauliWord({0:"Y", 1:"Y"})

H = 0.5 * XX + 0.7 * YY
>>> isinstance(H, PauliSentence)
True
```

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
Adding subtraction for PauliWord and PauliSentence to have full pauli
arithmetic together with
[Pauli1](#4989) and [Pauli
2](#5001).

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
Next PR after
[Pauli1](#4989),
[Pauli2](#5001) and
[Pauli3](#5003) that all
build on top of each other, adding documentation (and some integration
tests)

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017),
[Pauli5](#5018)

---------

Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
…5018)

Not dependent on previous Pauli PRs
([Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017)).

Add support in `qml.matrix` to handle `PauliWord` and `PauliSentence`
albi3ro added a commit that referenced this pull request Feb 9, 2024
Work in progress, some concepts like how best to treat identities need
some fine tuning.

see also [Pauli1](#4989),
[Pauli2](#5001),
[Pauli3](#5003),
[Pauli4](#5017), on top of
which this PR builds; as well as
[Pauli5](#5018)

---------

Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants