-
Notifications
You must be signed in to change notification settings - Fork 59
Remove "experimental_capture" kwarg from "qjit" #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "experimental_capture" kwarg from "qjit" #1657
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
==========================================
- Coverage 96.89% 96.88% -0.01%
==========================================
Files 80 80
Lines 8879 8871 -8
Branches 843 841 -2
==========================================
- Hits 8603 8595 -8
Misses 222 222
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dime10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much cleaner this way!
Is the integration documented anywhere in Catalyst I wonder? 🤔 @josh146 what do you think?
Only in two places as far as I am aware:
|
I'll update this accordingly |
And in the sharp bits page! |
Oh lol @josh146 I didn't read the link 🤦 hahaha |
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
albi3ro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice to have a consistent way of entering this ecosystem now.
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Raul! This is really nice to have 😎
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
…capture=True` (#7298) Related PR in Catalyst: PennyLaneAI/catalyst#1657 (cc @rauletorresc)
…capture=True` (#7298) Related PR in Catalyst: PennyLaneAI/catalyst#1657 (cc @rauletorresc)
…capture=True` (#7298) Related PR in Catalyst: PennyLaneAI/catalyst#1657 (cc @rauletorresc)
**Context:** Contributor's list is missing Raul's name while his [contribution](#1657) was made during this release. **Description of the Change:** Added Raul's name
Context: When dealing with transforms, the
experimental_capturekeyword fromqjitfails at capturing them because they are defined before the capture functionality has been activated. To circumvent this, program capture has to be enabled manually beforehand, which defies the purpose of the mentioned keyword. We propose using only the PL program capture enabling/disabling mechanism across the whole ecosystem to prevent such cases to happen.Description of the Change: Removed the
experimental_capturekeyword from itsqjitfunction in favor of aunified program capture behavior.
(#1657)
Program capture has to be enabled before the definition of the function to be qjitted.
For AOT compilation, program capture can be disabled right after the qjit usage and before execution.
But for JIT compilation, program capture cannot be disabled before execution,
otherwise the capture will not take place:
Benefits:
Before:
After:
Possible Drawbacks: Users might find it difficult to understand where exactly program capture should be enabled/disabled.
[sc-89121]