Switch to using experimental_capture qjit kwarg instead of global qml.capture.enabled()
#2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR is basically just to revert #1657 ....
We are currently using the global
qml.capture.enabled()kwarg to figure out if we are using the new frontend.The problem is that the global toggle controls both catalyst's frontend and how pennylane executes. But executing normal qnodes when capture is enabled is an unmaintained experimental feature. So we need to separate out using the program capture frontend in catalyst and executing with program capture in PennyLane.
Description of the Change:
Adds the
experimental_capturekwarg back ontoQJIT.Updates tests. So many tests.
Benefits:
We can turn program capture on with catalyst with also turning it on in pennylane executions.
Possible Drawbacks:
So many tests... Also just reverting something we had earlier 🤦♀️
Related GitHub Issues: