Skip to content

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Nov 20, 2020

Notes

  • Major
    • Related papers email system
  • Minor
    • Sitemap image URLs
    • Link out to preprint
    • UI updates for warnings and post-submit curator name
    • Skip failed exports to BioPAX
    • bug fixes

jvwong and others added 30 commits October 14, 2020 10:24
Supplement the sitemap urls with PNG image URL and metadata
Fixed a typo in effect of deubiquitination interaction type
Friendlier message for editor Task warnings
- Using the new component in the submit done TaskView to set name
… give an error message summarizing the case.
- Emphasize the editing state
Details:

- This is currently a prototype.
- A new email template type is defined as `relatedPaperNotification`.
- The emails are triggered whenever the related papers are updated for a document.
- A new metadata field is available on a document.  `doc.relatedPapersNotified()` can be used to set or get whether the notifications have been sent.  This prevents duplicates.
- Novel interactions are an optional enhancement in the emails:  An author can receive an email whether or not the originating factoid has a novel interaction.  However, if there is a novel interaction, this should be mentioned in the email.
- Currently, only notifications are sent to the terminal.  The emails are disabled until the template is set up.
- Action items are marked by `// TODO RPM`

Action items:

- [ ] Add a template to Mailjet (@jvwong), based on our email document on Google Docs.
- [ ] Reuse our Indra querying code to determine whether there is a novel interaction -- i.e. an interaction that has zero results in Indra (@metincansiper).
- [ ] Verify that our emails send correctly on unstable.  We'll temporary set unstable to send these notifications to Max and Jeff (@maxkfranz @jvwong).
- [ ] Finalise the email template text (@maxkfranz).
- [ ] Research the feasibility of the bonus 'factoidable' nudge:  Can we determine using AI whether a paper is a good candidate for Biofactoid?

Ref. : Novel interaction notification #858
- Add back no transition
During bulk export skip the files where the conversion is failing
Remove the date from the carousel entries
Chemical synonyms and formulae field labels shown if they exist
maxkfranz and others added 24 commits November 10, 2020 13:41
…possible : Removes the case where the dropdown resets to the top entry, when a non-first 'Which p53?' value is selected.
…se the visual identification of where a synonym starts and ends.
Provide author name parts and use in emails to ref'd paper authors
Applying additional selection criteria to emails for related papers
…881)

* Working on creating multiple documents from bioapax file through admin panel, nearly done!

* Improvements for uploading multiple articles through biopax

* Handle association of elements created through biopax urls.

* Bug fixes for creating multiple articles

* Fix linting error

* complete the entities created through biopax files

* Updated the non-exising email address specified for submitting multiple articles.

* A quick fix

* Skip emailing step for multiple article creations.

* Fixed linting errors

* Set the source of documents as either 'admin' or 'pc'

* Use uniprot id while grounding entities coming from biopax url.

* Consider other databases than uniprot while grounding entities for loading multiple documents

* A queick bug fix to set the elements paramater to an empty array in the service to create a document.
Expose the EMAIL_RELPPRS_CONTACT as a env variable in Docker.
@jvwong jvwong requested a review from maxkfranz November 20, 2020 20:04
@maxkfranz
Copy link
Member

fc71c85 should remove the 'not up to date' error beside the merge button

@jvwong jvwong merged commit e21626d into master Nov 21, 2020
@jvwong jvwong deleted the v0.13.0 branch December 9, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants