Skip to content

Carousel misc tweaks #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

Carousel misc tweaks #871

merged 2 commits into from
Oct 13, 2020

Conversation

@maxkfranz
Copy link
Member

Misc. fixes that would be good to include in the next release

@maxkfranz maxkfranz requested a review from jvwong October 13, 2020 13:58
@maxkfranz
Copy link
Member Author

maxkfranz commented Oct 13, 2020 •
edited
Loading

Example problematic doc:

Screen Shot 2020-10-13 at 10 00 15 AM (2)

@maxkfranz maxkfranz mentioned this pull request Oct 13, 2020
Merged
@maxkfranz
Copy link
Member Author

With fix:

Screen Shot 2020-10-13 at 10 14 29 AM (2)

@maxkfranz
Copy link
Member Author

Without smooth scroll:

no-smooth

With smooth scroll:

smooth

@maxkfranz maxkfranz merged commit 6751b85 into unstable Oct 13, 2020
@jvwong jvwong deleted the carousel-misc-tweaks branch October 13, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvwong jvwong jvwong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxkfranz @jvwong