Add support for average Lightning Tendrils DPS #8930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning Tendrils has a mechanic where it critically strikes every 3rd / 5th use but we were did not have a averaged calc for this There is now a new skill part for the averaged DPS I also applied DPS multipliers to the other 2 skill parts to show accurate DPS for just those parts when they hit as people may use the stronger pulse one to see DPS for Ignite
Averaging the crit chance and damage was not correct to get an accurate DPS value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightning Tendrils has a mechanic where it critically strikes every 3rd / 5th use but we were did not have a averaged calc for this
There is now a new skill part for the averaged DPS
I also applied DPS multipliers to the other 2 skill parts to show accurate DPS for just those parts when they hit as people may use the stronger pulse one to see DPS for Ignite
Fixes #7214, Fixes #6049, Fixes #4111
Before:
After:
