Skip to content

Conversation

@brendan-corrigan
Copy link
Contributor

@brendan-corrigan brendan-corrigan commented Jul 28, 2025

Description of the problem being solved:

Adding the option to add Beastcraft Modifiers to items via Add Modifier in the Item Crafter

Implemented Beastcrafts for the Following BaseTypee:

  • Beastcraft Suffixes for utility_flask
  • Beastcraft Suffixes for life_flasks
  • Beastcraft Aspects for all Equipment. Couldn't find any source on what base types are allowed. Wiki states any Equipment.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image image image

end)

writeMods("../Data/BeastCraft.lua", function(mod)
return (mod.Id:match("Aspect") and mod.GenerationType == 2) -- Aspect Crafts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm the officially unofficial imaginary mascot & chief pedant of PoB, and this line should be TAB indented. 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what the formatter settings are, EmmyLua was making changes across entire files, I would have thought that .editorconfig would work fine but its seems I'm missing a config.

I will go do that manually though

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 28, 2025
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few issues with the PR and also removed flasks from being included as they are the exact same as t3 regular immunity mods

@LocalIdentity LocalIdentity merged commit f68de28 into PathOfBuildingCommunity:dev Aug 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants