Adding Modifiers via "Add Modifier" to Tinctures Results in Crash

[brendan-corrigan]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Screenshots of crash/graphical issue, version and options menu

Using the Crafting Interface to create a Tincture shows the full list of Sources for additional mods.

All Sources are Empty:

Selecting any option other than Custom results in a crash:

What are your system specifications and configuration?

Windows 11

How to reproduce the issue

1. New build
2. Item Tab -> Craft Item -> Any Tincture
3. Click Add Modifier
4. Select any of the Mod Sources

PoB for PoE1 build code

[brendan-corrigan]

Quick solution would be to enclose the following block with a condition to exclude Tinctures:

PathOfBuilding/src/Classes/ItemsTab.lua

Lines 2696 to 2712 in 57552c7

	if self.displayItem.type ~= "Jewel" then
	t_insert(sourceList, { label = "Crafting Bench", sourceId = "MASTER" })
	end
	if self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask" then
	t_insert(sourceList, { label = "Essence", sourceId = "ESSENCE" })
	t_insert(sourceList, { label = "Veiled", sourceId = "VEILED"})
	end
	if self.displayItem.type == "Helmet" or self.displayItem.type == "Body Armour" or self.displayItem.type == "Gloves" or self.displayItem.type == "Boots" then
	t_insert(sourceList, { label = "Necropolis", sourceId = "NECROPOLIS"})
	end
	if not self.displayItem.clusterJewel and self.displayItem.type ~= "Flask" then
	t_insert(sourceList, { label = "Delve", sourceId = "DELVE"})
	end
	if not self.displayItem.crafted then
	t_insert(sourceList, { label = "Prefix", sourceId = "PREFIX" })
	t_insert(sourceList, { label = "Suffix", sourceId = "SUFFIX" })
	end