Sort the Calculations Tab breakdown lists by value #7211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a sort by type, but this is not used for a lot of breakdowns. Applying a sort by value should make it easier to read the breakdown without disrupting the sort by type.
Some breakdowns can contain a mix of `number` and `boolean`. e.g. the skill buffs breakdown if you have a golem active will have a `Condition: have golem` with value of `true`. The values in this kind of breakdown are pretty sparse and sorting them in a coherent way is not easy, so for the sake of this PR we can just keep skip(return false) when comparing number and boolean.
If we try to sort on the original modlist, we'll actually change the order of the values in memory and next time we sort again, some of the mods can move position. Using a copy of the table--which will be discarded after use--will prevent this.
1 task
LocalIdentity
approved these changes
Jan 11, 2024
LocalIdentity
requested changes
Jan 12, 2024
duiker101
changed the title
duiker101
changed the title
Breakdowns can also accept direct breakdown tables and slots values. These also need to be sorted by value.
|
Added sorting for both
|
LocalIdentity
approved these changes
Jan 13, 2024
|
Is that working? I'm using the new update and I don't see any difference. |
|
Yes, the value column on the left in your screenshot is sorted in descending order. Previously it would've been in a random order (it's possible the previous listing looked similar so you didn't notice the change) |
|
Yeah I'm stupid, was expecting alphabetical for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a sort by type, but this is not used for a lot of breakdowns. Applying a sort by value should make it easier to read the breakdown without disrupting the sort by type.
Fixes #4433 #7228
Description of the problem being solved:
The calculations breakdown popups are unsorted, making it harder to compare between builds.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: