Fix Attribute Requirement sorting #8814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jul 14, 2025
LocalIdentity
changed the title
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
Copy from PathOfBuildingCommunity/PathOfBuilding#8814 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
Copy from PathOfBuildingCommunity/PathOfBuilding#8814 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8813
Description of the problem being solved:
Required attributes was not being sorted in the breakdown, but Omni was on it's own. Setting the .source flag fixes this and let's us remove redundant sorting later as it is taken care of within CalcBreakdownControl now #7211.
At least that's the theory. Seems to work, makes sense to me, hope this is right. cross fingers
After screenshot:
Without Omni
With Omni