Add support for triggered skills with Snipe Support #6248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Snipe Support was not acting as a triggered skill for the skills it was linked to, this makes it use the channel time of Snipe to trigger linked attacks
This PR does not disable the damage of Snipe if linked to a skill it can trigger and doesn't take into account the number of stages for how many linked skills it can trigger at once
Relies on #6245 to show the channel time for Snipe
Link to a build that showcases this PR:
https://pobb.in/AExVimiod0fE
Before screenshot:
After screenshot: