Taken from allies before you #5943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local alliesTakenBeforeYou = poolTbl.alliesTakenBeforeYou | ||
| if not alliesTakenBeforeYou then | ||
| alliesTakenBeforeYou = {} | ||
| if output.FrostShieldLife then |
There was a problem hiding this comment.
Should frost shield be grouped inside an allies take damage before you table?
There was a problem hiding this comment.
frost shield is its own entity and doesnt count as you taking the damage, hence being grouped as a "non-you" entity
|
The calculations look correct afaik. The only potential inaccuracy is which takes damage first sceptre or totem but should be irrelevant for the most part. |
Regisle
force-pushed
the
takenFromAlliesBeforeYou
branch
from
fa28ce3 to
d92a329
Compare
|
(added |
Co-authored-by: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Regisle
force-pushed
the
takenFromAlliesBeforeYou
branch
from
d92a329 to
19713a5
Compare
LocalIdentity
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks how taken from allies before you is handled to make it more generic to make it easier to support more sources in the future (like
Vaal Rejuvenation Totem), as well as adding support forThe Jinxed Jujumod10% of Damage from Hits is taken from your Spectres' Life before youand the totem mastery
5% of Damage from Hits is taken from your nearest Totem's Life before you