Support for a missing "Jinxed Juju" unique amulet mod

[mullinger]

Previously, the special mod the the Jinxed Juju Amulet was not supported:

10% of Damage from Hits is taken from your Spectres' Life before you

This commit adds support for the mod in regards to the damage taken calculations.

I assume that the calculations in-game might be slightly different, though the differences are probably in the sub-percent range.
This patch should give a pretty good addition for now.

[Regisle]

This needs to only be active if your specters have enough life to take the damage (make a config option) as there are builds who use the amulet without specters

[mullinger]

@Regisle Very good point, thanks for your comment.
Instead of adding yet another config options I thought about checking if the player actually has an active spectre skill.

Without active spectre skill, or of the spectre skill is disabled the mod from the amulet will not be applied.

What do you think?

[ppoelzl]

There should be some kind of calculation on how much damage is actually transferable to the spectre.
Also in your code you spelled it "specter", not "spectre", which is our preferred spelling @mullinger

[Wires77]

There should be some kind of calculation on how much damage is actually transferable to the spectre.

Eh, I'm not sure this is necessary, even the weakest spectres have almost 10k health, so you'd need to take 100k damage before that's something to worry about.

I'm all for not adding more config options, too, so just basing it off of the player having an active spectre skill seems like the right way to go to me.

[mullinger]

E.g. Apes have unbuffed 16k max HP without any investment .
At lvl 20 gem you can have 3 apes with a total pool of around 48k HP.

I'm down with any decision (Config option or without) as I can see the benefits of both implementations. Just need a decision :-)

[deathbeam]

This is not 10% less damage taken, this should work like mind over matter because its same mechanic.

[Wires77]

If we're fine assuming the spectres will always have enough health to give you the damage mitigation, I've added a suggestion for a simpler way to implement this

[Wires77]

@deathbeam is correct, this implementation isn't right. It should act as another multiplier on top of other reduced * less damage modifiers you have.

I can merge this as a 10% less damage taken, and open an issue to fix it properly later, or we can keep it open and do it properly from the start. React if you don't want to comment but want to vote on one over the other.

👍 Merge now, fix later
👎 Don't merge until properly implemented

[ppoelzl]

No need to rush out unfinished features "just because".

[QuickStick123]

Superseded by #5943