Skip to content

Conversation

@deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Apr 3, 2023

Closes #5898
Closes #4868
Closes #6098
Closes #6129

Works for life/mana flasks, life to es conversion and mana to life
conversion.

Steps taken to verify a working solution:

  • Grab source of enduring flask (either mod on mana flask or master surgeon)
  • See recovery added correctly

Link to a build that showcases this PR:

https://pobb.in/W4nODPE8kVxc

Before screenshot:

image

image

image

After screenshot:

image

image

image

@deathbeam
Copy link
Contributor Author

This also accidentally fixes magic utility flask effect that broke again because I fixed life flask conditions as this line was wrong (it should've checked for item base and not for conditions as those are global)
image

@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Apr 3, 2023
@deathbeam deathbeam force-pushed the flask-regen branch 6 times, most recently from 7dffb69 to 55dc4c7 Compare April 7, 2023 01:33
@deathbeam deathbeam changed the title Add support for enduring flask recovery to be displayed as regen Add support for enduring flask recovery to be displayed as life/es recovery Apr 7, 2023
@deathbeam deathbeam force-pushed the flask-regen branch 3 times, most recently from a2e8951 to bc0a8da Compare April 7, 2023 02:40
@QuickStick123
Copy link
Contributor

Also fixes #6129

…covery

Works for life/mana flasks, life to es conversion and mana to life
conversion.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@LocalIdentity LocalIdentity merged commit 2ce878e into PathOfBuildingCommunity:dev Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

4 participants