Master Alchemist 20% increased effect of magic ultility Flasks is not caluclated

[JonasHaba]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

The rarity value in the calculation should go up.
Because the "Abecedarian's Gold Flask of the Order" Flask should get 20% increased effect.

What is the actual behaviour/value?

The Flask is getting the 20% effect, but the rarity in the calcs isn't going up.

How to reproduce the issue

Click on "Master Alchemist" go to calc.
Look at the number.
Do it again.
Look at the number.

Rarity without Master Alchemist: 635%
Rarity with Master Alchemist: 635%

Character build code

https://pastebin.com/j2LsXMS1

Screenshots

No response

[QuickStick123]

This is not an issue
With

Without

[afishyate]

I've also had issues with this node since implemented.
-It randomly has no effect on all, or sometimes one or two particular magic utility flasks
-It doesn't seem to happen at all on newly created POB profiles
-It seems to happen often on big/old POB profiles, with 5+ tree/gem/gear sets
-Sometimes these profiles work normally after restarting POB, but then become dysfunctional after some time

[QuickStick123]

Can you provide a build code that this occurs on?

[afishyate]

https://pastebin.com/MErDA0AC
I have:
Jade + Evasion
Silver + Resistance
Quicksilver + Movespeed

Each time I open the build, and re-allocate the Master Alchemist, random sidebar stats go unchanged, or none change.
e.g., Movement speed increases, but resists and evasion do not.

edit: Also happens with this, with Quartz instead of Jade:
https://pastebin.com/BVARHjmp

Again, upon first opening everything works, Suppress + Evasion + Resistance + MS changes.
Go back, re-open, and Resistance doesn't change.
Go back, re-open, nothing changes,
Go back, re-open, all change except Evasion.

[QuickStick123]

There is something odd going on here re openning.

[QuickStick123]

It seems certain mods arn't getting scaled correctly by the magic thing namely movement speed flask suffix, jade flask prefix and evasion suffix by magic flask effect.

[afishyate]

Correct. The strangest part is how random it is. Whether or not a stat is affected, can be changed by:
-Re-opening the profile
-Making several changes to items in the profile
-Making a new identical flask seems to 'fix' the broken/unaffected stats
-Sometimes doing these things fixes some/everything, sometimes it does nothing

Feels like each time I open the profile, I get a random bug seed lol.

[afishyate]

-Just discovered, that activating ANY mana flask creates the bug
-Tried a new profile, all my old ones, and new/imported profiles in 2.20.1.
-Every time, activating any mana flask removes MA's 20% flask effect from some or all of the stats affected by magic utility flask mods.
-In fact, in my profiles posted, activating the magic Mana Flask, or Lavianga's Spirit, will remove/add back different stats from the utility flasks
-Highlighting the flask in item menu shows the correct Flask Effect #, only the sidebar is affected.