Skip to content

Fix broken mastery import state #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fix broken mastery import state #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5bb9f
Fix broken mastery import state
Lothrik Jul 13, 2022
316cb63
Update PassiveSpec.lua
Lothrik Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Classes/PassiveSpec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,15 @@ end

function PassiveSpecClass:AllocateMasteryEffects(masteryEffects)
for i = 1, #masteryEffects - 1, 4 do

local effectId = masteryEffects:byte(i) * 256 + masteryEffects:byte(i + 1)
local id = masteryEffects:byte(i + 2) * 256 + masteryEffects:byte(i + 3)

self.masterySelections[id] = effectId
local effect = self.tree.masteryEffects[effectId]
self.allocNodes[id].sd = effect.sd
self.allocNodes[id].allMasteryOptions = false
self.allocNodes[id].reminderText = { "Tip: Right click to select a different effect" }
self.tree:ProcessStats(self.allocNodes[id])
self.masterySelections[id] = effectId
self.allocatedMasteryCount = self.allocatedMasteryCount + 1
end
end
Expand Down
6 changes: 3 additions & 3 deletions src/Classes/PassiveTreeView.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,8 +916,8 @@ function PassiveTreeViewClass:AddNodeTooltip(tooltip, node, build)
end

local function addModInfoToTooltip(node, i, line)
if node.mods[i].list then
if launch.devModeAlt then
if node.mods[i] then
if launch.devModeAlt and node.mods[i].list then
-- Modifier debugging info
local modStr
for _, mod in pairs(node.mods[i].list) do
Expand All @@ -930,8 +930,8 @@ function PassiveTreeViewClass:AddNodeTooltip(tooltip, node, build)
line = line .. " " .. modStr
end
end
tooltip:AddLine(16, ((node.mods[i].extra or not node.mods[i].list) and colorCodes.UNSUPPORTED or colorCodes.MAGIC)..line)
end
tooltip:AddLine(16, ((node.mods[i].extra or not node.mods[i].list) and colorCodes.UNSUPPORTED or colorCodes.MAGIC)..line)
end

-- If node is a Mastery node, check if compare tree is on
Expand Down