Edit & Retry - Enhancing the web controller's response for a scenario when Edit & Retry is ignored #5127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
andreasohlund
approved these changes
Oct 10, 2025
cquirosj
changed the title
| { | ||
| logger.LogWarning("Cannot edit message {FailedMessageId} because it has already been edited", failedMessageId); | ||
| // We return HTTP 200 even though the edit is being ignored. This is to keep the compatibility with older versions of ServicePulse. | ||
| // Newer ServicePulse versions (starting with x.x) will handle the response's payload accordingly. |
There was a problem hiding this comment.
How will we know to get back to here and update the comment? ;-) Maybe we can put the current version here and state the "newer versions will handle it"
SzymonPobiega
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5122