Skip to content

POC: Move editAndRetry handler logic to WebController #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

POC: Move editAndRetry handler logic to WebController #5125

wants to merge 4 commits into from

Conversation

cquirosj
Copy link
Contributor

@cquirosj cquirosj commented Oct 1, 2025

TODO:

  • Do another pass to clean up the controller code
  • Return payload for ServicePulse usage (when a retry has already happened)
  • Inform the ServicePulse user about a failed retry (internal server errors - http 500)
  • Remove the handler and corresponding types (message, etc.)

Christian added 3 commits October 2, 2025 09:44
More tests passing
5cd2af4
Dont not use failed message id as the attempt id
2f37369 
Receive this as a parameter is something we might want to do as was only applicable for the NSB handler version
address lint error
0a398f6
@cquirosj
Copy link
Contributor Author

cquirosj commented Oct 7, 2025

closed in favor of

@cquirosj cquirosj closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bartekwasielak bartekwasielak

@cquirosj cquirosj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cquirosj @bartekwasielak