2119 spatial hashing #2132
Merged
2119 spatial hashing #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think what remains here in this PR is to compare initial spatial hash search in a larger example with the original curvilinear search. Working on this now. |
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Nice one, @fluidnumerics-joe! See below some comments/questions.
Also removed dependencies on uxarray internal API in the process of making this change
erikvansebille
approved these changes
Aug 13, 2025
erikvansebille
added a commit
to Parcels-code/parcels-benchmarks
that referenced
this pull request
Aug 13, 2025
Meant to compare the spatial hashing (Parcels-code/Parcels#2132) against the old (vectorized) search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)This PR adds in a new spatialhash class that is meant to be used in the initial search for particles on curvilinear grids. It also brings in a change in the
_search_indices_curvilinear_2dinternal function. The initial guess for the particle location is set to the value provided by a spatial hash query.