Fix Webpack & Browserslist Deprecation Warnings #2269
Conversation
WalkthroughThe pull request introduces updates to the Changes
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2269 +/- ##
========================================
Coverage 97.54% 97.54%
========================================
Files 241 241
Lines 6887 6887
Branches 2016 2016
========================================
Hits 6718 6718
Misses 157 157
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details. Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done Also make sure the title is easily searchable for terms related to what the PR is about. |
There was a problem hiding this comment.
Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.
Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done
Also make sure the title is easily searchable for terms related to what the PR is about.
patches/react-scripts+5.0.1.patch
Outdated
| @@ -1,11 +1,3 @@ | ||
| -// @remove-on-eject-begin | ||
| -/** | ||
| - * Copyright (c) 2015-present, Facebook, Inc. |
There was a problem hiding this comment.
Why have you removed the comments? Others will need to reference this in future and without the context it will be harder.
There was a problem hiding this comment.
Sir I have not removed any comments these are the comments that are generated when we install node_modules
There was a problem hiding this comment.
I will add comments to the file to make it self-explanatory.
akathedeveloper
changed the title
What kind of change does this PR introduce?
Refactoring and enhancement
Issue Number: #2258
Fixes #
Did you add tests for your changes?
No
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
This pull request addresses the deprecation warnings related to Webpack Dev Server in the react-scripts package by updating the configuration in webpack.config.js. Specifically, it replaces the deprecated onBeforeSetupMiddleware and onAfterSetupMiddleware options with the new setupMiddlewares option.
Additionally, a new postinstall script has been added to the package.json file:
Changes Made:
Replaced onBeforeSetupMiddleware and onAfterSetupMiddleware with setupMiddlewares in webpack.config.js.
Added "postinstall": "patch-package" to package.json to apply patches automatically.
Testing
Does this PR introduce a breaking change?
NO
Other information
The PR includes a necessary update to the react-scripts package configuration to comply with the latest Webpack Dev Server standards. This change ensures continued compatibility and prevents future issues with deprecated configuration options.
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Summary by CodeRabbit
New Features
patch-packagetool.Improvements
Bug Fixes