Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick some changes from incubate branch #8862

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Aug 2, 2024

PR types

Bug fixes

PR changes

Others

Description

Cherry pick some changes from incubate branch. The PRs include #8837, #8846, #8851 .

Copy link

paddle-bot bot commented Aug 2, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 8.79121% with 83 lines in your changes missing coverage. Please review.

Project coverage is 55.38%. Comparing base (77480a0) to head (2049374).

Current head 2049374 differs from pull request most recent head 6699d74

Please upload reports for the commit 6699d74 to get more accurate results.

Files Patch % Lines
paddlenlp/trainer/utils/reshard/sharding_v2.py 11.11% 40 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 7.40% 25 Missing ⚠️
paddlenlp/trainer/trainer.py 7.69% 12 Missing ⚠️
paddlenlp/trainer/training_args.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8862      +/-   ##
===========================================
- Coverage    55.41%   55.38%   -0.04%     
===========================================
  Files          635      631       -4     
  Lines        99917    98653    -1264     
===========================================
- Hits         55370    54639     -731     
+ Misses       44547    44014     -533     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit dbf395f into PaddlePaddle:develop Aug 6, 2024
9 of 12 checks passed
@sneaxiy sneaxiy deleted the cherry_pick_some_changes_from_incubate_branch branch August 6, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants