Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sharding reshard compatible with wrong master weight names #8851

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jul 31, 2024

PR types

Bug fixes

PR changes

Others

Description

Make sharding reshard compatible with wrong master weight names.

Copy link

paddle-bot bot commented Jul 31, 2024

Thanks for your contribution!

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 84d7845 into PaddlePaddle:incubate/paddlenlp-fleety Jul 31, 2024
3 of 5 checks passed
@sneaxiy sneaxiy deleted the fix_sharding_reshard_compat branch July 31, 2024 12:02
sneaxiy added a commit to sneaxiy/PaddleNLP that referenced this pull request Aug 2, 2024
wawltor pushed a commit that referenced this pull request Aug 6, 2024
* Fix sharding reshard bug and support reshard in different partition ways (#8837)

* Fix sharding reshard bug and support reshard in different partition ways

* fix some bugs

* refine codes

* revert some useless codes

* add log

* Fix TP sync (#8846)

* fix sharding reshard compatiblity for wrong master weight name (#8851)

* change print to logger.info

* remove useless f-string
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (6cf97de) to head (dca8a99).
Report is 32 commits behind head on incubate/paddlenlp-fleety.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/sharding_io.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           incubate/paddlenlp-fleety    #8851      +/-   ##
=============================================================
- Coverage                      55.21%   55.20%   -0.01%     
=============================================================
  Files                            620      620              
  Lines                          96639    96649      +10     
=============================================================
+ Hits                           53355    53356       +1     
- Misses                         43284    43293       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants