【Infer Symbolic Shape BUAA No.10 No.73 No.78】Add mode , margin_cross_entropy , box_clip. op #66730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
test_index_select_strided.py 中已包含OpTest单测，self.check_output() 确认使用，申请approve流水线 |
gongshaotian
reviewed
Aug 6, 2024
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc
Show resolved
Hide resolved
crazyxiaoxi
force-pushed
the
cinn/margin
branch
from
fc57009 to
b1be1fc
Compare
crazyxiaoxi
force-pushed
the
cinn/margin
branch
from
b1be1fc to
1fecfe5
Compare
zyfncg
reviewed
Aug 9, 2024
|
|
||
| for (size_t i = 0; i < logits_rank; i++) { | ||
| if (i != axis) { | ||
| infer_context->AddBroadcastableCstr(logits_dims[i], labels_dims[i]); |
Hongqing-work
approved these changes
Aug 9, 2024
Hongqing-work
requested changes
Aug 9, 2024
Comment on lines
743
to
746
|
|
||
| if (labels_dims.size() > 1) { | ||
| infer_context->AddEqualCstr(logits_dims[axis], one); | ||
| } |
Contributor
There was a problem hiding this comment.
这里逻辑和infer meta不太符合，和之前的相等约束一并修改后再合并吧
Contributor
Author
Merge branch 'cinn/mode' into cinn/margin
crazyxiaoxi
changed the title
crazyxiaoxi
changed the title
|
|
||
| if (labels_dims.size() > 1) { | ||
| infer_context->AddEqualCstr(logits_dims[axis], one); | ||
| infer_context->AddEqualCstr(labels_dims[axis - 1], one); |
Contributor
There was a problem hiding this comment.
infer meta里是检查labels_dims[logits_rank - 1]是否等于1，再确认下是否一致吧
Contributor
Author
There was a problem hiding this comment.
上面是infermeta的定义
检查labels_dims[logits_rank - 1]是否等于1
下面是opinfersymbolicshape
确实在写的时候不需要 ' axis-1' 只用axis = logits_rank -1
Contributor
There was a problem hiding this comment.
那下一个PR顺带修复一下吧，提的时候把这个PR链接带上
Hongqing-work
approved these changes
Aug 12, 2024
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…entropy , box_clip. op (PaddlePaddle#66730) * mode * boxclip * test_op * testop * margin_cross_entropy_op * resolve conflict * resolve conflict * resolve conflict * testop * testop * testop * tensor * fix fix conflict fix conflict fix conflict * fix * test * fix problem * fix equal * Update unused viriable * static check * rerun * add cstr * fix small problem * equal constrain * change change change * codestyle * fix error * comment fix * fix comment * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
improvements
Description
添加mode , margin_cross_entropy,box_clip算子符号推导接口
均已检查Optest