[BUAA]【Infer Symbolic Shape No.10】Add box_clip op #66629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
test_box_clip_op.py中已包含OpTest单测，self.check_output() 确认使用，申请approve流水线 |
gongshaotian
reviewed
Aug 5, 2024
| common::errors::InvalidArgument("The rank of Input(input) in BoxClipOp " | ||
| "must be 4. But received rank = %d", | ||
| input_dims.size())); | ||
| PADDLE_ENFORCE_EQ( |
Contributor
There was a problem hiding this comment.
DimExpr的约束应该用 Addequalcstr()
gongshaotian
reviewed
Aug 5, 2024
| "The rank of Input(im_info) in BoxClipOp must be 2. " | ||
| "But received rank = %d", | ||
| im_info_dims.size())); | ||
| PADDLE_ENFORCE_EQ( |
Contributor
Author
There was a problem hiding this comment.
infermeta里面只有和非零数的比较，没有两个shape之间的比较没法实现...把这部分代码给删除了
Contributor
There was a problem hiding this comment.
可以实现的，用常量数据创建一个DimExpr，然后添加约束
crazyxiaoxi
force-pushed
the
cinn/boxclip
branch
from
69c72a5 to
c862a90
Compare
crazyxiaoxi
changed the title
crazyxiaoxi
force-pushed
the
cinn/boxclip
branch
from
c862a90 to
591ae2e
Compare
gongshaotian
reviewed
Aug 8, 2024
| infer_context->GetShapeOrDataForValue(op->operand_source(1)); | ||
|
|
||
| // Check rank and dimensions of input tensors | ||
| if (op->attribute<pir::BoolAttribute>("is_runtime").data()) { |
Contributor
Author
There was a problem hiding this comment.
刘旭东也遇到了类似的问题，把这个is_runtime判断给移除了
gongshaotian
reviewed
Aug 8, 2024
| // Check rank and dimensions of input tensors | ||
| if (op->attribute<pir::BoolAttribute>("is_runtime").data()) { | ||
| const auto &input_dims = input_shape.shape(); | ||
| const auto &im_info_dims = im_info_shape.shape(); |
Contributor
There was a problem hiding this comment.
命名不规范，示例：input_shape、im_info_shape
gongshaotian
reviewed
Aug 8, 2024
| if (op->attribute<pir::BoolAttribute>("is_runtime").data()) { | ||
| const auto &input_dims = input_shape.shape(); | ||
| const auto &im_info_dims = im_info_shape.shape(); | ||
| const auto three = symbol::DimExpr{3}; |
Contributor
Author
|
test_box_clip_op.py中已包含OpTest单测，本地测试通过 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
improvements
Description
添加box_clip算子符号推导接口
test/legacy_test/test_box_clip_op.py 已经包含 check_test_output