Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest] reformat example code with google style No.241-245 #56359

Merged
merged 6 commits into from
Aug 25, 2023
Merged

[xdoctest] reformat example code with google style No.241-245 #56359

merged 6 commits into from
Aug 25, 2023

Conversation

PommesPeter
Copy link
Contributor

@PommesPeter PommesPeter commented Aug 16, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码，使其通过 xdoctest 检查：

  • ./python/paddle/distributed/auto_parallel/static/functional.py
  • ./python/paddle/distributed/auto_parallel/static/primapi.py
  • ./python/paddle/distributed/auto_parallel/static/primreg.py
  • ./python/paddle/distributed/auto_parallel/primx.py
  • ./python/paddle/distributed/utils.py

预览：

en: http://preview-paddle-pr-56359.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/en/api/paddle/abs_en.html
zh: http://preview-paddle-pr-56359.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/paddle/abs_cn.html

关联 PR：

@sunzhongkai588 @SigureMo @megemini

@paddle-bot
Copy link

paddle-bot bot commented Aug 16, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 16, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 17, 2023
megemini
megemini reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体没啥问题，不过里面有些用到 fluid 的接口，可能晚点时间（月底？）要统一修改一下～

@luotao1
Copy link
Contributor

luotao1 commented Aug 18, 2023

不过里面有些用到 fluid 的接口，可能晚点时间（月底？）要统一修改一下～

是先合入这个PR，晚点时间新开一个任务么？还是晚点时间改完再合入？ @sunzhongkai588

@SigureMo SigureMo changed the title [xdoctest] reformat example code with google style No.241-245 [waiting for fluid rename][xdoctest] reformat example code with google style No.241-245 Aug 18, 2023
@SigureMo
Copy link
Member

是先合入这个PR，晚点时间新开一个任务么？还是晚点时间改完再合入？ @sunzhongkai588

我觉得晚点再合吧，这个本来就是第三批的任务，另外合入大概率会导致 #56281 冲突，优先 #56281 合入吧

@SigureMo SigureMo changed the title [waiting for fluid rename][xdoctest] reformat example code with google style No.241-245 [xdoctest] reformat example code with google style No.241-245 Aug 24, 2023
SigureMo
SigureMo approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 closed this Aug 25, 2023
@luotao1 luotao1 reopened this Aug 25, 2023
@luotao1 luotao1 merged commit 2e3a190 into PaddlePaddle:develop Aug 25, 2023
@luotao1 luotao1 mentioned this pull request Aug 25, 2023
Closed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@PommesPeter @SigureMo @BeingGod
[xdoctest] reformat example code with google style No.241-245 (Paddle…
7119e99 
…Paddle#56359)

* fix: refine code examples

* fix: refine detail

* refactor: refine detail

* refactor: refine detail

* fix: refine code style.

* Update python/paddle/incubate/autograd/functional.py

---------

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
@SigureMo SigureMo mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megemini megemini megemini left review comments

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PommesPeter @luotao1 @SigureMo @megemini @sunzhongkai588