Skip to content

[Prim] Fix silu backward prim bug #56280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[Prim] Fix silu backward prim bug #56280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d6cf7
fix silu backward prim bug
cyber-pioneer Aug 14, 2023
94f7ee0
fix silu double grad prim
cyber-pioneer Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions paddle/fluid/prim/api/composite_backward/composite_backward_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,21 @@ void silu_grad(const Tensor& x,
const Tensor& out_grad,
Tensor* x_grad) {
if (x_grad) {
auto sigmoid = out / x;
auto res = out_grad * sigmoid * (1.0 + x * (1.0 - sigmoid));
set_output<T>(res, x_grad);
auto org_dtype = x.dtype();
bool need_cast = org_dtype == phi::DataType::FLOAT16 ||
org_dtype == phi::DataType::BFLOAT16;
if (need_cast) {
auto x_cast = cast<T>(x, phi::DataType::FLOAT32);
auto out_cast = cast<T>(out, phi::DataType::FLOAT32);
auto out_grad_cast = cast<T>(out_grad, phi::DataType::FLOAT32);
auto sigmoid = 1.0 / (1.0 + exp<T>(-x_cast));
auto res = out_grad_cast * sigmoid * (1.0 + x_cast - out_cast);
set_output<T>(cast<T>(res, org_dtype), x_grad);
} else {
auto sigmoid = 1.0 / (1.0 + exp<T>(-x));
auto res = out_grad * sigmoid * (1.0 + x - out);
set_output<T>(res, x_grad);
}
}
}

Expand Down
5 changes: 2 additions & 3 deletions paddle/fluid/prim/api/composite_backward/composite_double_backward_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,16 +439,15 @@ void silu_double_grad(const Tensor& x,
const Tensor& grad_x_grad,
Tensor* grad_x,
Tensor* grad_out_grad) {
auto sigmoid = out / x;
auto sigmoid = 1 / (1 + exp<T>(-x));
auto tmp1 = 1 - sigmoid;
auto tmp2 = 1 + tmp1 * x;
if (grad_out_grad) {
auto ddout = grad_x_grad * sigmoid * tmp2;
set_output<T>(ddout, grad_out_grad);
}
if (grad_x) {
auto dx =
sigmoid * grad_x_grad * out_grad * (1 + (tmp2 - x * sigmoid)) * tmp1;
auto dx = sigmoid * grad_x_grad * out_grad * (1 + (tmp2 - out)) * tmp1;
set_output<T>(dx, grad_x);
}
}
Expand Down