Skip to content

Conversation

@cyber-pioneer
Copy link
Contributor

@cyber-pioneer cyber-pioneer commented Aug 14, 2023

PR types

Bug fixes

PR changes

Others

Description

Pcard-66975
To fix 2 accuracy bugs inside composite rule of silu_grad:

  1. accuracy loss where input type is float16. Origin kernel will promote data dtype in such case;
  2. overflow when input is approximate to 0.

@paddle-bot
Copy link

paddle-bot bot commented Aug 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果不需要out 可以修改回原来的参数列表https://github.com/PaddlePaddle/Paddle/pull/53632/files

@cyber-pioneer
Copy link
Contributor Author

如果不需要out 可以修改回原来的参数列表https://github.com/PaddlePaddle/Paddle/pull/53632/files

使用out可以减少一个乘法算子

Copy link
Contributor

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer cyber-pioneer merged commit 08dbb33 into PaddlePaddle:develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants