[NewExe] update run checks of standalone executor #52313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
pangyoki
reviewed
Mar 31, 2023
| if ( | ||
| compiled_program._build_strategy is not None | ||
| and compiled_program._build_strategy.allow_cuda_graph_capture | ||
| and not _is_cuda_graph_enable_standalone_executor() |
There was a problem hiding this comment.
如果这个判断不需要了，_is_cuda_graph_enable_standalone_executor()和FLAGS_CUDA_GRAPH_USE_STANDALONE_EXECUTOR环境变量是不是都可以删掉了？
There was a problem hiding this comment.
是的，后续打算和其他flag一起删除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Delete the following checks which are used to decide whether use
StandaloneExecutoror not:core.is_compiled_with_mlu(): mlu related code is moved toPaddleCustomDevicenow, this line has no effectasync_mode: added in Skip async mode for standalone executor #45599 andStandaloneExecutornow supports those unit testsallow_cuda_graph_capture:StandaloneExecutornow supports this caseOthers
Pcard-67004