Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip async mode for standalone executor #45599

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Aug 31, 2022

PR types

Others

PR changes

Others

Describe

program._graph是CompiledProgram的情况下会使用回转方案。
使用回转方案时,如下单测失败:

test_dist_fleet_ctr
test_dist_fleet_simnet
test_dist_fleet_sparse_embedding_ctr

这些单测中program._graph回转后,create_py_reader op中的device_count属性会从1变为2。
这几个单测都使用了async mode,新执行器不会支持这种case,所以直接在回转方案里跳过了。

注:
之前的写法里,只有program为CompiledProgram的情况下才会有一些特殊case的跳过逻辑。这个PR里让program为Program且program._graph为CompiledProgram的情况也应用这些跳过逻辑。

之前跳过分布式的case现在打开了限制。

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangyoki pangyoki merged commit 230fd50 into PaddlePaddle:develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants