[Phi] mv kernel #39861
Merged
[Phi] mv kernel #39861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, It's a test PR, it will not trigger CI. If you want to trigger CI, please remove |
windstamp
force-pushed
the
npu_dev_phi_20220223
branch
2 times, most recently
from
1c1a3df to
f168115
Compare
windstamp
force-pushed
the
npu_dev_phi_20220223
branch
from
f168115 to
ea81b5c
Compare
windstamp
force-pushed
the
npu_dev_phi_20220223
branch
from
ea81b5c to
9ef3ab6
Compare
windstamp
force-pushed
the
npu_dev_phi_20220223
branch
from
9ef3ab6 to
588929a
Compare
chenwhql
approved these changes
Feb 25, 2022
| } // namespace phi | ||
|
|
||
| PD_REGISTER_KERNEL(mv_grad, CPU, ALL_LAYOUT, phi::MvGradKernel, float, double) { | ||
| } |
There was a problem hiding this comment.
这个pre-commit处理的换行吗，有点别扭，不如直接在kernel name那里换个行
There was a problem hiding this comment.
是的，pre-commit 某种情况下会这样自动更新一下，后来我又改回来了，但是又会导致 CI (应该是 PR-CI-Static-Check) 失败，必须这样才能通过。
你们是否可以和 PR-CI-Static-Check 确认一下，这种看着确实有点别扭。
|
|
||
| namespace phi { | ||
|
|
||
| KernelSignature MvOpArgumentMapping(const ArgumentMappingContext& ctx) { |
There was a problem hiding this comment.
这个op挺标准的，可以不用写这个函数，建议后续PR移除
zyfncg
approved these changes
Feb 25, 2022
|
|
||
| namespace phi { | ||
|
|
||
| KernelSignature MvOpArgumentMapping(const ArgumentMappingContext& ctx) { |
There was a problem hiding this comment.
这里前向的Mapping映射应该可以不写，使用默认op_proto映射即可，可以在后续PR里完善下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
[Phi] mv kernel