-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[Phi] mv kernel #39861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
windstamp
merged 1 commit into
PaddlePaddle:develop
from
windstamp:npu_dev_phi_20220223
Feb 25, 2022
Merged
[Phi] mv kernel #39861
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include "paddle/phi/kernels/mv_grad_kernel.h" | ||
|
||
#include "paddle/phi/backends/cpu/cpu_context.h" | ||
#include "paddle/phi/core/kernel_registry.h" | ||
#include "paddle/phi/kernels/funcs/blas/blas.h" | ||
|
||
namespace phi { | ||
|
||
template <typename T, typename Context> | ||
void MvGradKernel(const Context& dev_ctx, | ||
const DenseTensor& x, | ||
const DenseTensor& vec, | ||
const DenseTensor& out_grad, | ||
DenseTensor* x_grad, | ||
DenseTensor* vec_grad) { | ||
auto dout = out_grad; | ||
auto dx = x_grad; | ||
auto dvec = vec_grad; | ||
|
||
auto dim_x = x.dims(); | ||
int m = dim_x[0]; | ||
int n = dim_x[1]; | ||
|
||
// get data ptr | ||
const T* x_data = x.data<T>(); | ||
const T* vec_data = vec.data<T>(); | ||
const T* dout_data = dout.data<T>(); | ||
|
||
if (dx) { | ||
T* dx_data = dev_ctx.template Alloc<T>(dx); | ||
|
||
for (int i = 0; i < m; ++i) { | ||
for (int j = 0; j < n; ++j) { | ||
dx_data[i * n + j] = dout_data[i] * vec_data[j]; | ||
} | ||
} | ||
} | ||
|
||
if (dvec) { | ||
T* dvec_data = dev_ctx.template Alloc<T>(dvec); | ||
|
||
auto blas = phi::funcs::GetBlas<Context, T>(dev_ctx); | ||
|
||
blas.GEMV(true, | ||
dim_x[0], | ||
dim_x[1], | ||
static_cast<T>(1), | ||
x_data, | ||
dout_data, | ||
static_cast<T>(0), | ||
dvec_data); | ||
} | ||
} | ||
|
||
} // namespace phi | ||
|
||
PD_REGISTER_KERNEL(mv_grad, CPU, ALL_LAYOUT, phi::MvGradKernel, float, double) { | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include "paddle/phi/kernels/mv_kernel.h" | ||
|
||
#include "paddle/phi/backends/cpu/cpu_context.h" | ||
#include "paddle/phi/core/kernel_registry.h" | ||
|
||
#include "paddle/phi/kernels/impl/mv_kernel_impl.h" | ||
|
||
PD_REGISTER_KERNEL(mv, CPU, ALL_LAYOUT, phi::MvKernel, float, double) {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个pre-commit处理的换行吗,有点别扭,不如直接在kernel name那里换个行
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,pre-commit 某种情况下会这样自动更新一下,后来我又改回来了,但是又会导致 CI (应该是 PR-CI-Static-Check) 失败,必须这样才能通过。
你们是否可以和 PR-CI-Static-Check 确认一下,这种看着确实有点别扭。