Update doc about how to write new operators. #3734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
force-pushed
the
write_new_op
branch
from
408c814 to
1f60d9f
Compare
qingqing01
force-pushed
the
write_new_op
branch
from
1f60d9f to
c19eae4
Compare
typhoonzero
previously approved these changes
Aug 29, 2017
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM++
One minor comment which doesn't block merging.
| computation will use these variables. | ||
| :param inputs_to_check: inputs var names that should check gradient. | ||
| :param output_name: output name that used to | ||
| :param output_name: the final output variable name. |
Contributor
There was a problem hiding this comment.
the final output variable name. => the output variable name.
Contributor
|
wiki中的Operator代码规范，能不能也更新到文档中呢？主要是命名上的一些规范需要列出来。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3732