[paddle.linalg.qr] Add the Qr Operator #35742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Restore the deleted comma
fuyinno4
previously approved these changes
Sep 22, 2021
dingjiaweiww
approved these changes
Sep 23, 2021
| def qr(x, mode="reduced", name=None): | ||
| r""" | ||
| Computes the QR decomposition of one matrix or batches of matrice. | ||
| Args: |
| If mode = "r", qr will return a tensor which represents R. | ||
|
|
||
| Examples: | ||
| import paddle |
There was a problem hiding this comment.
import paddle 之前需要加入：.. code-block:: python
参考文档：http://agroup.baidu.com/paddlepaddle/md/article/3088623
dingjiaweiww
previously approved these changes
Sep 23, 2021
python/paddle/__init__.py
Outdated
| @@ -504,6 +505,7 @@ | |||
| 'sqrt', | |||
| 'cholesky', | |||
| 'matrix_power', | |||
| 'qr', | |||
There was a problem hiding this comment.
线性代数API 不需要在paddle.* 下面暴露
aoyulong
dismissed stale reviews from dingjiaweiww and fuyinno4
via
640915a
dingjiaweiww
previously approved these changes
Sep 23, 2021
jeff41404
reviewed
Sep 26, 2021
python/paddle/__init__.py
Outdated
| @@ -105,6 +105,7 @@ | |||
| from .tensor.linalg import slogdet # noqa: F401 | |||
| from .tensor.linalg import multi_dot # noqa: F401 | |||
| from .tensor.linalg import matrix_power # noqa: F401 | |||
| from .tensor.linalg import qr # noqa: F401 | |||
There was a problem hiding this comment.
should not add this line, otherwise we have paddle.qr
chenwhql
reviewed
Sep 26, 2021
paddle/fluid/operators/qr_op.h
Outdated
| compute_q = false; | ||
| reduced = true; | ||
| } else { | ||
| PADDLE_ENFORCE( |
There was a problem hiding this comment.
仅CUDA Kernel内的PADDLE_ENFORCE不需要加报错类型，这里也是需要加类型的，而且这里我理解用PADDLE_THROW更合适一些
paddle/fluid/operators/qr_op.h
Outdated
| class QrGradKernel : public framework::OpKernel<T> { | ||
| public: | ||
| void Compute(const framework::ExecutionContext& ctx) const { | ||
| PADDLE_ENFORCE( |
TCChenlong
previously approved these changes
Sep 26, 2021
zhhsplendid
previously approved these changes
Sep 26, 2021
chenwhql
previously approved these changes
Sep 26, 2021
aoyulong
dismissed stale reviews from chenwhql, zhhsplendid, TCChenlong, zhiqiu, and Superjomn
via
2fec228
|
Sorry to inform you that 5356a09's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add paddle.linalg.qr() function, Qr Op and Qr GPU/CPU kernel.
Note: Qr Op of this pull request doesn't have the backward kernels for now.