Skip to content

Document That Precision As Displayed Is Not Supported #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleibman merged 1 commit into from
May 25, 2025
Merged

Document That Precision As Displayed Is Not Supported #4484

oleibman merged 1 commit into from
May 25, 2025

Conversation

@oleibman
Copy link
Collaborator

@oleibman oleibman commented May 25, 2025

Fix #1247. Aside from being difficult to implement, see, for example, https://answers.microsoft.com/en-us/msoffice/forum/all/what-are-the-dangers-of-using-precision-as/1a2ba5eb-9470-452f-816e-d7961c0d0ad5

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • documentation

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

@oleibman oleibman added this pull request to the merge queue May 25, 2025
Merged via the queue into PHPOffice:master with commit 9da522f May 25, 2025
14 checks passed
@oleibman oleibman deleted the issue1247 branch May 25, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Take Account of 'Precision as Displayed'

1 participant

@oleibman