bugfix: specific borders were not written correctly in word2007

[pscheit]

testcode:

    $cell = $row->addCell(400, array(
      'borderRightColor'=>'efefef',
      'borderRightSize'=>40,
      'borderBottomColor'=>'efefef',
      'borderBottomSize'=>40,
    ));

displays only rightBorder but not the bottomBorder.

Sorry for no unit test. Would you prefer the XMLWriter to be injected and then the xml output tested or mocking the XMLWriter and testing the behaviour with expectations? (difficult with PHPUnit only, I would suggest using mockery)
Unfortuately I cannot write the unit test right now, but still hope this bug will be fixed

[pscheit]

btw: do you want to achieve that all contributors PR against develop? You should put this in contributors.md then...
and I think you can change the default branch for pull requests in admin settings

[Progi1984]

@pscheit Don't hesitate to open a pull request for improving any of your ideas :)

For the default branch in admin settings, it's the default branch when you arrive on this Github project, and by extension, when you open a PR.

[carlosrochap]

is this already implemented?, I'm having the same issue. Thanks

update: I just copied the changes in the commit and it's working fine, when would this be pushed to master?

[Progi1984]

It has been merged to the develop branch. It will be released in the next version.