Skip to content

Conversation

@pscheit
Copy link
Contributor

@pscheit pscheit commented Jul 15, 2014

testcode:

    $cell = $row->addCell(400, array(
      'borderRightColor'=>'efefef',
      'borderRightSize'=>40,
      'borderBottomColor'=>'efefef',
      'borderBottomSize'=>40,
    ));

displays only rightBorder but not the bottomBorder.

Sorry for no unit test. Would you prefer the XMLWriter to be injected and then the xml output tested or mocking the XMLWriter and testing the behaviour with expectations? (difficult with PHPUnit only, I would suggest using mockery)
Unfortuately I cannot write the unit test right now, but still hope this bug will be fixed

@pscheit
Copy link
Contributor Author

pscheit commented Jul 22, 2014

hey guys, can you merge that? Something missing?

@Progi1984
Copy link
Member

@pscheit Two points :

  • Could you push your pull request to the develop branch and not the master branch ?
  • Could you add a line in Changelog.md, please ?
    And I will merge your commit after. Thanks

@pscheit
Copy link
Contributor Author

pscheit commented Aug 4, 2014

okay now its here #327

@pscheit pscheit closed this Aug 4, 2014
@Progi1984 Progi1984 self-assigned this Aug 4, 2014
@Progi1984 Progi1984 added this to the 0.12.0 milestone Aug 4, 2014
@pscheit pscheit deleted the bugfix-margin-border branch August 4, 2014 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants