Bugfix: not all borders are written when specific borders specified #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testcode:
displays only rightBorder but not the bottomBorder.
Sorry for no unit test. Would you prefer the XMLWriter to be injected and then the xml output tested or mocking the XMLWriter and testing the behaviour with expectations? (difficult with PHPUnit only, I would suggest using mockery)
Unfortuately I cannot write the unit test right now, but still hope this bug will be fixed