Skip to content

Conversation

@dbarzin
Copy link
Contributor

@dbarzin dbarzin commented May 7, 2020

Description

Add a function in the Word templateProcessor

Fixes # 1058

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@snazy2000
Copy link

@dbarzin just tried this from your repo but even the sample just returns a corrupt docx file?

@dbarzin
Copy link
Contributor Author

dbarzin commented Jun 6, 2020

Check made from my github and it is working fine. Here is what I have done :

git clone https://github.com/dbarzin/PHPWord
cd PHPWord
composer install
cd samples
php ./Sample_41_TemplateSetChart.php

The generated file is in results/Sample_41_TemplateSetChart.docx

fixes #1865 Colors not applied correcty in stacked_column charts
@dbarzin
Copy link
Contributor Author

dbarzin commented Jun 6, 2020

Add fixes for #1865 Colors not applied correcty in stacked_column charts

@snazy2000
Copy link

I was doing it directly from the browser and when it generated the document it hasn't put anything inside the content_types which is why it was then corrupt

I had to change it to the following to get it to work

snazy2000@78a3eb7

Also correct me if I'm wrong but your most recent commit about colours looks like you've removed all the ability to write charts? lol Looks like stamped over Part\chart.php with Element\chart.php :)

@dbarzin
Copy link
Contributor Author

dbarzin commented Jun 8, 2020

The invalid commit has been reverted.

Have you tried the sample 41(Sample_41_TemplateSetChart.php) ? For an easy access to those samples launch php -S localhost:8000 in the samples directory then browse to http://localhost:8000 to view the samples.

@snazy2000
Copy link

Yes I have and it doesn't work in Windows Word, haven't tried Openoffice.

@dbarzin
Copy link
Contributor Author

dbarzin commented Jun 8, 2020 via email

This reverts commit c79653c.
@dbarzin
Copy link
Contributor Author

dbarzin commented Jun 8, 2020 via email

@dbarzin dbarzin closed this Jun 8, 2020
@dbarzin dbarzin reopened this Jun 8, 2020
@dbarzin dbarzin closed this Jun 8, 2020
@dbarzin dbarzin reopened this Jun 8, 2020
@dbarzin dbarzin closed this Jun 8, 2020
@dbarzin dbarzin reopened this Jun 9, 2020
@dbarzin dbarzin marked this pull request as draft January 11, 2021 15:39
@dbarzin dbarzin requested a review from troosan January 11, 2021 15:40
@troosan troosan added this to the v0.18.0 milestone Feb 5, 2021
@troosan troosan marked this pull request as ready for review February 5, 2021 20:50
@troosan
Copy link
Contributor

troosan commented Feb 6, 2021

will be merged with #2012

@troosan troosan closed this Feb 6, 2021
@troosan troosan removed this from the v0.18.0 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants