[BUGFIX] allow to load unclean html without exception #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is only supported as of PHP 5.4 so as long as we support 5.3 we cannot include this |
Author
|
How about making a new version without 5.3 support. EOL has been long ago |
Contributor
|
indeed, it's planned, will be for the next version, if not 1.0 |
Closed
|
Hi. Will this PR merged soon ? |
|
For anyone else interested in this (for example, if PHP 5.3 support is dropped), I've prepared for this with a fork that resolves the merge conflicts at develop...anotherjames:patch-1 |
Author
|
We use composer patching to avoid these kind of problems |
|
@kaystrobach so do I... I must be missing something! :) What do you have in your composer.json to get around it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #754